pytorch / multipy

torch::deploy (multipy for non-torch uses) is a system that lets you get around the GIL problem by running multiple Python interpreters in a single C++ process.

Other

174 stars 35 forks source link

Disable pybind11's GIL checks #325

Closed EthanSteinberg closed 1 year ago

EthanSteinberg commented 1 year ago

pybind11 recently added a feature to assert that the GIL is held during reference counting operations https://github.com/pybind/pybind11/pull/4246

This feature has already uncovered several instances of undefined behavior in several Python extensions.

However, this code does not seem to pass these checks, which is preventing us from upgrading PyTorch to the latest pybind11. See https://github.com/pytorch/pytorch/pull/105245

This PR disables those checks, which will in turn allow PyTorch to upgrade.

Note that this code already has known potential GIL issues:

https://github.com/pytorch/multipy/blob/bd1c76f294335695db8bfa66250781c1627f4eb7/multipy/runtime/deploy.cpp#L59

facebook-github-bot commented 1 year ago

Hi @Lalaland!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

EthanSteinberg commented 1 year ago

CC @Skylion007

EthanSteinberg commented 1 year ago

Hmm. Not sure why the CLA check is failing. I signed the CLA.

Skylion007 commented 1 year ago

@EthanSteinberg Is the email address you used to author the commits part of you GH account? that could be causing it.

EthanSteinberg commented 1 year ago

@Skylion007 Looks like it fixed itself. I guess it just took a second.

facebook-github-bot commented 1 year ago

@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@albanD merged this pull request in pytorch/multipy@d0032e0d9d757a7d31ee5b4eacb47d9f4d383143.