coverage via coveralls in CircleCI

arn7av commented 1 year ago

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs change / refactoring / dependency upgrade

(None of the above - changes are made to CI pipeline)

Motivation and Context / Related issue

The objective was to have code coverage made publicly accessible via https://coveralls.io To achieve this, the following changes were made:

move existing tests running via pytest & unittest to run via coverage
add dependency of coverage in dev_requirements.txt, followed by coveralls in CircleCI config
minor refactoring of tasks to prepare for upload to coveralls
upload coverage reports generated in parallel to coveralls as CircleCI tasks
at the end of workflow, signal coveralls to combine all parallel uploads under single run

How Has This Been Tested (if it applies)

Testing changes made to CircleCI config is tricky. Most of the code was tested via opening this PR and letting CircleCI run on this new config. Some obscure parts were tested in a personal CircleCI environment.

Checklist

[ ] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

ashkan-software commented 1 year ago

Thanks for working on this. Let me know when you are done :)

facebook-github-bot commented 1 year ago

@arn7av has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@arn7av has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@arn7av has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pytorch / opacus