Closed ffuuugor closed 1 year ago
@ffuuugor has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@ffuuugor has updated the pull request. You must reimport the pull request before landing.
@ffuuugor has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Conv3d grad sample test is failing currently: CircleCI
This is most likely due to a difference in
unfold3d
method between opacus and EW implementations.Opacus:
EW:
As dilation other than 1 is not supported under any conditions with EW, I've fixed then
is_ew_compatible
flag.PS: @ashkan-software do we have a github issue to update EW's
unfold3d
with the recent updates you made?