feat: update lightning example to lightning 2.0

pytorch / opacus

Training PyTorch models with differential privacy

https://opacus.ai

Apache License 2.0

1.65k stars 328 forks source link

Open lsc64 opened 10 months ago

lsc64 commented 10 months ago

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Docs change / refactoring / dependency upgrade

Updates the lightning example to use a less hacky way to change datamodules. https://github.com/Lightning-AI/lightning/issues/10430

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

facebook-github-bot commented 10 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 9 months ago

@lsc64 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 9 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

lsc64 commented 9 months ago

Thanks for the PR! There is a minor bug in the variable name. I'm surprised the integration test passed despite this though.

One could think it’s possible to add two lines without a major oversight, but here we are… thanks, I’ve changed it!

facebook-github-bot commented 6 months ago

@lsc64 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 6 months ago

@lsc64 has updated the pull request. You must reimport the pull request before landing.

lsc64 commented 6 months ago

friendly ping @karthikprasad I think your review is implemented. let me know if something else is missing