pytorch / opacus

Training PyTorch models with differential privacy
https://opacus.ai
Apache License 2.0
1.65k stars 328 forks source link

Simplify `lightning` example dataloader access #627

Open eonu opened 5 months ago

eonu commented 5 months ago

Types of changes

Motivation and Context / Related issue

Since Torch 2.0, there is now a cleaner way of accessing the training dataloader in the LightningModule.configure_optimizers function.

https://github.com/Lightning-AI/pytorch-lightning/issues/10430#issuecomment-1487753339

This PR applies that change to the Lightning MNIST example notebook.

How Has This Been Tested (if it applies)

Checklist

facebook-github-bot commented 5 months ago

Hi @eonu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!