Fix BatchMemoryManager length - Githubissues

pytorch / opacus

Training PyTorch models with differential privacy

https://opacus.ai

Apache License 2.0

1.72k stars 345 forks source link

Fix BatchMemoryManager length #641

Closed dwahdany closed 6 months ago

dwahdany commented 8 months ago

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

Fixes #640 by ceiling the number of batches.

How Has This Been Tested (if it applies)

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

facebook-github-bot commented 8 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 8 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 8 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 6 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 6 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

dwahdany commented 6 months ago

Could you add this missing line back? The current version fails the lint test (https://app.circleci.com/pipelines/github/pytorch/opacus/3256/workflows/26b31f87-1e6e-4562-b070-59dc983bdf4e/jobs/18514?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary). Then I will approve the pr. Thx!

Sorry my styling constantly changed everything around. Files changed now shows only two changed lines, hope it works now!

facebook-github-bot commented 6 months ago

This pull request has been merged in pytorch/opacus@7d65ddf37565adf0fc11de7dab826d4e26a44704.