pytorch / opacus

Training PyTorch models with differential privacy

https://opacus.ai

Apache License 2.0

1.65k stars 328 forks source link

Pass kwargs from make_private to _prepare_optimizer #648

Closed eigengravy closed 3 weeks ago

eigengravy commented 2 months ago

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

Pass kwargs from make_private to _prepare_optimizer to allow extra arguments to the optimizer. Closes #559

How Has This Been Tested (if it applies)

Tested and confirmed the colab notebook in the attached issue works.

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

facebook-github-bot commented 2 months ago

Hi @eigengravy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 2 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

HuanyuZhang commented 1 month ago

Thanks for contribution! Let me take a look and let you know.

facebook-github-bot commented 4 weeks ago

@HuanyuZhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@HuanyuZhang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@HuanyuZhang merged this pull request in pytorch/opacus@36196192ffe107604c025212f58f87073242a3e8.