search

pytorch / probot

PyTorch GitHub bot written in probot
ISC License
11 stars 13 forks source link

deprecation of `number` for octokit #62

Open seemethere opened 3 years ago

seemethere commented 3 years ago

Affects auto-cc-bot:

      Deprecation: [@octokit/rest] "number" parameter is deprecated for ".issues.get()". Use "issue_number" instead
          at /home/runner/work/pytorch-probot/pytorch-probot/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/register-endpoints.js:47:34
          at Array.forEach (<anonymous>)
          at Object.forEach [as get] (/home/runner/work/pytorch-probot/pytorch-probot/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/register-endpoints.js:44:30)
          at CachedIssueTracker.<anonymous> (/home/runner/work/pytorch-probot/pytorch-probot/src/utils.ts:57:55)
          at step (/home/runner/work/pytorch-probot/pytorch-probot/src/utils.ts:46:23)
          at Object.next (/home/runner/work/pytorch-probot/pytorch-probot/src/utils.ts:27:53)
          at fulfilled (/home/runner/work/pytorch-probot/pytorch-probot/src/utils.ts:18:58)

See https://github.com/pytorch/pytorch-probot/runs/3488345303

malfet commented 3 years ago

Actually, I closed this one by https://github.com/pytorch/pytorch-probot/commit/6f6a5b3ff0665e15f1f09407c91403c0f225caf4

But few more remains, for example:

      Deprecation: [@octokit/rest] "number" parameter is deprecated for ".issues.update()". Use "issue_number" instead
          at /home/runner/work/pytorch-probot/pytorch-probot/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/register-endpoints.js:47:34
          at Array.forEach (<anonymous>)
          at Object.forEach [as update] (/home/runner/work/pytorch-probot/pytorch-probot/node_modules/@octokit/plugin-rest-endpoint-methods/dist-src/register-endpoints.js:44:30)
          at /home/runner/work/pytorch-probot/pytorch-probot/src/auto-cc-bot.ts:61:39
          at step (/home/runner/work/pytorch-probot/pytorch-probot/src/auto-cc-bot.ts:33:23)
          at Object.next (/home/runner/work/pytorch-probot/pytorch-probot/src/auto-cc-bot.ts:14:53)
          at fulfilled (/home/runner/work/pytorch-probot/pytorch-probot/src/auto-cc-bot.ts:5:58)