search

pytorch / pytorch.github.io

The website for PyTorch
https://pytorch.org
BSD 3-Clause "New" or "Revised" License
222 stars 285 forks source link

Add new blog post "The Path to Achieve Pytorch Windows Performance boost on CPU" #1630

Open ZhaoqiongZ opened 4 months ago

ZhaoqiongZ commented 4 months ago

Add new post "The Path to Achieve Pytorch Windows Performance boost on CPU"

netlify[bot] commented 4 months ago

Deploy Preview for pytorch-dot-org-preview processing.

Name Link
Latest commit 0d25e501755f8bd9923a164517c6da41fbf8cde3
Latest deploy log https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/666fa95aff2e110008aaa565
ZhaoqiongZ commented 4 months ago

Hi @cjyabraham , I just create this PR for adding a new blog post "The Path to Achieve Pytorch Windows Performance boost on CPU", I saw that you merged most of the post PRs, could you help review the PR and help merge it. Thanks a lot!

cjyabraham commented 4 months ago

Hi @ZhaoqiongZ, the images don't appear to be rendering correctly. I think you may need to adjust their paths. You could also make the image captions italics or something to help them stand out.

Also tagging @kyliewd here to review from a content POV.

ZhaoqiongZ commented 4 months ago

Hi @cjyabraham , thanks for your advice! I've make the title of image bold and italics to help them stand out. The images appear correctly in my side and I double checked the paths, they are also correct. Please refresh the post https://github.com/ZhaoqiongZ/pytorch.github.io/blob/5-21-addpost/_posts/2024-05-21-perfboost-windows-cpu.md . The images locates at https://github.com/ZhaoqiongZ/pytorch.github.io/tree/5-21-addpost/assets/images/2024-05-21-perfboost-windows-cpu and I used a relative path to show it. Let me know if you still get issue on image rendering.

cjyabraham commented 4 months ago

The images are not showing up in the preview here. Try setting their paths to just /assets/images/2024-05-21-perfboost-windows-cpu/pytorch_20_win_linux.png

Also, take a look at this post to see how I add styling info to the image tags to get them to fill the width of the page correctly.

ZhaoqiongZ commented 4 months ago

Hi @cjyabraham , thanks a lot for your help, I correct the path and also the width. It seems correctly in the preview now!

kyliewd commented 4 months ago

@ZhaoqiongZ was this approved by your marketing team? unfortunately we have to go through review processes before posting on the official blog. please check in with them and follow up with me. thanks!

xuhancn commented 4 months ago

@ZhaoqiongZ was this approved by your marketing team? unfortunately we have to go through review processes before posting on the official blog. please check in with them and follow up with me. thanks!

@kyliewd We have passed company internal review process, but we didn't known who is the Intel marketing team contactor. So we post the blog by ourself, could you please add Intel marking team contact to the reviewer?

ZhaoqiongZ commented 4 months ago

Hi @kyliewd , this was approved by our dev team and legal team. Please go ahead to review, I will follow up with you. Thanks in advance!

ZhaoqiongZ commented 3 months ago

Hi @kyliewd , This blog is now approved by our marketing team.