pytorch / pytorch

Tensors and Dynamic neural networks in Python with strong GPU acceleration
https://pytorch.org
Other
82.15k stars 22.08k forks source link

DISABLED test_transformerencoderlayer_cuda_float32 (__main__.TestNNDeviceTypeCUDA) #134687

Open jithunnair-amd opened 2 weeks ago

jithunnair-amd commented 2 weeks ago

Platforms: rocm

Broken by https://github.com/pytorch/pytorch/pull/133331

cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

pytorch-bot[bot] commented 2 weeks ago
Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below: * Test name: `test_transformerencoderlayer_cuda_float32 (__main__.TestNNDeviceTypeCUDA)` * Platforms for which to skip the test: rocm * Disabled by `jithunnair-amd` Within ~15 minutes, `test_transformerencoderlayer_cuda_float32 (__main__.TestNNDeviceTypeCUDA)` will be disabled in PyTorch CI for these platforms: rocm. Please verify that your test name looks correct, e.g., `test_cuda_assert_async (__main__.TestCuda)`. To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified. ``` Platforms: case-insensitive, list, of, platforms ``` We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows. ### How to re-enable a test To re-enable the test globally, close the issue. To re-enable a test for only a subset of platforms, remove the platforms from the list in the issue body. This may take some time to propagate. To re-enable a test only for a PR, put `Fixes #134687` in the PR body and rerun the test jobs. Note that if a test is flaky, it maybe be difficult to tell if the test is still flaky on the PR.
janeyx99 commented 2 weeks ago

Is there going to be a followup fix?

jithunnair-amd commented 2 weeks ago

@xinyazhang, I believe you will be filing a github issue to discuss the proposed fix?

xinyazhang commented 2 weeks ago

@janeyx99 @jithunnair-amd I'm not very familiar with the process, should I start an issue, or file a PR directly if I thought I found a solution?

janeyx99 commented 2 weeks ago

Feel free to file an issue to discuss the fix and link to this one.

xinyazhang commented 1 week ago

Feel free to file an issue to discuss the fix and link to this one.

Filed as https://github.com/pytorch/pytorch/issues/135150 @jithunnair-amd @janeyx99