search

pytorch / pytorch

Tensors and Dynamic neural networks in Python with strong GPU acceleration
https://pytorch.org
Other
82.26k stars 22.13k forks source link

Contributing to Caffe2 #19726

Closed ArutyunovG closed 4 years ago

ArutyunovG commented 5 years ago

This issue is a continuation of the discussion, started in #19264

First of all. thank you very much (@BIT-silence in particular) for accepting review, despite everything.

Here I'd like to discuss better format for future cooperation in order to have better coordination with the team and avoid such situations.

I'm sorry in case my changes were unexpected and not interesting. It comes as a surprise for me, to be honest, becuase before development, interest was stated in #13896 and #13550 and (based on answers) thought there was an interest.

For future, is there an interest in new detection/general computer vision ops for Caffe2 in your team?

My interests include object detection, keypoint detection and instance segmentation. And plan was to use Caffe2 at the company I'm working in as an Inference Engine for NVIDIA GPUs. Actually, we already do such usage and will continue for some time whatever the future of Caffe2 is. It is not simple just to change development pipelines in a matter of days.

If there is general interest in new caffe2 ops, what are they? Are there limitations? How is better to ask in issues before making submissions to avoid such situations?

I also do Windows build fix PRs on a regular basis. We are Windows-based production developers and those techincal PRs resolve our daily issues with updating Caffe2 to current master. Is it ok to continue adding them without discussion in issues?

Thanks for taking your time, Grigory

cc @dzhulgakov @soumith cc @ezyang @peterjc123 (as reviewers for previous Windows fixes part)

ArutyunovG commented 4 years ago

We added CenterNet postprocessing implementation for our internal usage. Commit link. I.e. one can train it in pytorch and deploy freezed graph in Caffe2 with this layer. I'm not sure if anchor-free detectors are interesting for you, so if the answer is positive please let me know.

ArutyunovG commented 4 years ago

Always available for contact.