search

pytorch / rl

A modular, primitive-first, python-first PyTorch library for Reinforcement Learning.
https://pytorch.org/rl
MIT License
2.05k stars 273 forks source link

[BugFix] Make `_reset` follow `done` shape #2189

Closed matteobettini closed 1 month ago

matteobettini commented 1 month ago

Fixes #2179 Replaces #2181

By enforcing resets to have the same shape as dones

pytorch-bot[bot] commented 1 month ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2189

Note: Links to docs will display an error until the docs builds have been completed.

:x: 5 New Failures, 1 Unrelated Failure

As of commit 14f904ab1d2fa1184bd4c59257c97ae5cea0484c with merge base c0c32a03761f1c20317f7e898888f76b4a73facc (image):

NEW FAILURES - The following jobs have failed:

* [Continuous Benchmark (PR) / CPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2189#25651258191) ([gh](https://github.com/pytorch/rl/actions/runs/9318600550/job/25651258191)) `Workflow failed! Resource not accessible by integration` * [Continuous Benchmark (PR) / GPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2189#25651257431) ([gh](https://github.com/pytorch/rl/actions/runs/9318600550/job/25651257431)) `Workflow failed! Resource not accessible by integration` * [Habitat Tests on Linux / tests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2189#25651259337) ([gh](https://github.com/pytorch/rl/actions/runs/9318600573/job/25651259337)) `RuntimeError: Command docker exec -t 6a37831e4fd8439bcfbd10b49c7a61df4eab4526a0c58b9bcdb0d63e04802550 /exec failed with exit code 139` * [Unit-tests on Linux / tests-optdeps (3.10, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2189#25651263443) ([gh](https://github.com/pytorch/rl/actions/runs/9318600579/job/25651263443)) `RuntimeError: Command docker exec -t 413fdd4fd13cf56e05abe6864322c0e7c104bd756bb15a05e9ca34aea7db1a4d /exec failed with exit code 1` * [Unit-tests on Windows / unittests-cpu / windows-job](https://hud.pytorch.org/pr/pytorch/rl/2189#25651264883) ([gh](https://github.com/pytorch/rl/actions/runs/9318600583/job/25651264883)) `The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128`

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

* [Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2189#25651262899) ([gh](https://github.com/pytorch/rl/actions/runs/9318600579/job/25651262899)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/c0c32a03761f1c20317f7e898888f76b4a73facc#25645348732)) `test/test_transforms.py::TestVecNorm::test_state_dict_vecnorm`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

matteobettini commented 1 month ago

Pls add environment label to test pettingzoo