Closed vmoens closed 4 weeks ago
Note: Links to docs will display an error until the docs builds have been completed.
There are 1 currently active SEVs. If your PR is affected, please view them below:
As of commit 71381a2e5db2382e3cc2ff0b0c8c070ec0635618 with merge base 47a1005d27244cc984df88cdd36940cbc19f5fa3 ():
* [Habitat Tests on Linux / tests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2224#26121038411) ([gh](https://github.com/pytorch/rl/actions/runs/9480417128/job/26121038411)) `RuntimeError: Command docker exec -t dc88aa1564b633062060298143548141d25a151ad5dfc4f6155f4c296b9a79a8 /exec failed with exit code 139` * [Unit-tests on Linux / tests-optdeps (3.10, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2224#26121065556) ([gh](https://github.com/pytorch/rl/actions/runs/9480417130/job/26121065556)) `RuntimeError: Command docker exec -t 432f93a480dd7b5f7c000744d0b7654c713754f01787faae4667755b709ac72b /exec failed with exit code 1`
👉 Rebase onto the `viable/strict` branch to avoid these failures
* [Libs Tests on Linux / unittests-gym (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2224#26121060811) ([gh](https://github.com/pytorch/rl/actions/runs/9480417138/job/26121060811)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/47a1005d27244cc984df88cdd36940cbc19f5fa3#26119114864)) `##[error]The operation was canceled.` * [Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2224#26121066951) ([gh](https://github.com/pytorch/rl/actions/runs/9480417130/job/26121066951)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/47a1005d27244cc984df88cdd36940cbc19f5fa3#26119114192)) `##[error]The operation was canceled.`
This comment was automatically generated by Dr. CI and updates every 15 minutes.
This PR enables assigning values to a RB.
This is slightly bc-breaking: Previously doing
storage[index] = foo
was exactly equivalent tostorage.set(index, foo)
. Now only the second will update the cursor position. This lets us assigning values without telling the buffer that we have moved the cursor.TODO:
cc @wertyuilife2