pytorch / rl

A modular, primitive-first, python-first PyTorch library for Reinforcement Learning.
https://pytorch.org/rl
MIT License
2.01k stars 269 forks source link

[BugFix] Fix max value within buffer during update priority #2242

Closed vmoens closed 2 weeks ago

vmoens commented 2 weeks ago

cc @wertyuilife2

pytorch-bot[bot] commented 2 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2242

Note: Links to docs will display an error until the docs builds have been completed.

:x: 7 New Failures, 12 Unrelated Failures

As of commit e8d17ef27eabbca55f914a9d0f4a901e924c4dcb with merge base 1d729e8f1ce4728afa3bcae75bc3c684f5dc59bd (image):

NEW FAILURES - The following jobs have failed:

* [Continuous Benchmark (PR) / CPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2242#26521730590) ([gh](https://github.com/pytorch/rl/actions/runs/9615178848/job/26521730590)) `Process completed with exit code 1.` * [Continuous Benchmark (PR) / GPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2242#26521731318) ([gh](https://github.com/pytorch/rl/actions/runs/9615178848/job/26521731318)) `Process completed with exit code 1.` * [Continuous Benchmark / CPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2242#26521730522) ([gh](https://github.com/pytorch/rl/actions/runs/9615178852/job/26521730522)) `AttributeError: 'TanhNormal' object has no attribute 'deterministic_sample'` * [Unit-tests on Linux / tests-cpu (3.10) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521733032) ([gh](https://github.com/pytorch/rl/actions/runs/9615178876/job/26521733032)) `test/test_transforms.py::TestKLRewardTransform::test_kl_lstm` * [Unit-tests on Linux / tests-cpu (3.11) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521733682) ([gh](https://github.com/pytorch/rl/actions/runs/9615178876/job/26521733682)) `test/test_transforms.py::TestKLRewardTransform::test_kl_lstm` * [Unit-tests on Linux / tests-cpu (3.8) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521734486) ([gh](https://github.com/pytorch/rl/actions/runs/9615178876/job/26521734486)) `test/test_transforms.py::TestKLRewardTransform::test_kl_lstm` * [Unit-tests on Linux / tests-cpu (3.9) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521735052) ([gh](https://github.com/pytorch/rl/actions/runs/9615178876/job/26521735052)) `test/test_transforms.py::TestKLRewardTransform::test_kl_lstm`

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

* [Examples Tests on Linux / tests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521732131) ([gh](https://github.com/pytorch/rl/actions/runs/9615178875/job/26521732131)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [Generate documentation / build-docs (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521732922) ([gh](https://github.com/pytorch/rl/actions/runs/9615178871/job/26521732922)) ([similar failure](https://hud.pytorch.org/pytorch/rl/commit/e8d17ef27eabbca55f914a9d0f4a901e924c4dcb#26521732129)) * [Habitat Tests on Linux / tests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521732117) ([gh](https://github.com/pytorch/rl/actions/runs/9615178867/job/26521732117)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [Libs Tests on Linux / unittests-gym (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521739108) ([gh](https://github.com/pytorch/rl/actions/runs/9615178874/job/26521739108)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [Libs Tests on Linux / unittests-sklearn (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521739400) ([gh](https://github.com/pytorch/rl/actions/runs/9615178874/job/26521739400)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [Lint / python-source-and-configs / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521732400) ([gh](https://github.com/pytorch/rl/actions/runs/9615178879/job/26521732400)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [RLHF Tests on Linux / unittests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521732987) ([gh](https://github.com/pytorch/rl/actions/runs/9615178877/job/26521732987)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [Unit-tests on Linux / tests-gpu (3.10, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521735738) ([gh](https://github.com/pytorch/rl/actions/runs/9615178876/job/26521735738)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521736003) ([gh](https://github.com/pytorch/rl/actions/runs/9615178876/job/26521736003)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [Unit-tests on Linux / tests-optdeps (3.10, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521736326) ([gh](https://github.com/pytorch/rl/actions/runs/9615178876/job/26521736326)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521736666) ([gh](https://github.com/pytorch/rl/actions/runs/9615178876/job/26521736666)) (matched **linux** rule in [flaky-rules.json](https://github.com/pytorch/test-infra/blob/generated-stats/stats/flaky-rules.json)) `The process '/usr/bin/git' failed with exit code 128` * [Unit-tests on Windows / unittests-cpu / windows-job](https://hud.pytorch.org/pr/pytorch/rl/2242#26521732129) ([gh](https://github.com/pytorch/rl/actions/runs/9615178868/job/26521732129)) (detected as infra flaky with no runner)

This comment was automatically generated by Dr. CI and updates every 15 minutes.