search

pytorch / rl

A modular, primitive-first, python-first PyTorch library for Reinforcement Learning.
https://pytorch.org/rl
MIT License
2.19k stars 289 forks source link

[Tests] Fix VMAS tests #2287

Closed matteobettini closed 2 months ago

pytorch-bot[bot] commented 2 months ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2287

Note: Links to docs will display an error until the docs builds have been completed.

:x: 4 New Failures, 1 Unrelated Failure

As of commit fc1387c9740c4b79f2c9daaf4f99167a3a0c02f5 with merge base ea79350584e0063175a64df29178422c767c1f4b (image):

NEW FAILURES - The following jobs have failed:

* [Continuous Benchmark (PR) / CPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2287#27274696945) ([gh](https://github.com/pytorch/rl/actions/runs/9874296798/job/27274696945)) `Workflow failed! Resource not accessible by integration` * [Continuous Benchmark (PR) / GPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2287#27274697488) ([gh](https://github.com/pytorch/rl/actions/runs/9874296798/job/27274697488)) `Workflow failed! Resource not accessible by integration` * [Examples Tests on Linux / tests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2287#27274699646) ([gh](https://github.com/pytorch/rl/actions/runs/9874296832/job/27274699646)) `RuntimeError: Command docker exec -t 1d3a2e65ff0a5d01da2588f2101e93266fe7b13300c4a21e2fdfe2c4dbd15645 /exec failed with exit code 1` * [Habitat Tests on Linux / tests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2287#27274700731) ([gh](https://github.com/pytorch/rl/actions/runs/9874296861/job/27274700731)) `RuntimeError: Command docker exec -t f8772889fa11b2700fc86b37f3f93cc4b7a4556f2e563734179a1b978c36d7be /exec failed with exit code 139`

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

* [Unit-tests on Windows / unittests-cpu / windows-job](https://hud.pytorch.org/pr/pytorch/rl/2287#27274698056) ([gh](https://github.com/pytorch/rl/actions/runs/9874296845/job/27274698056)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/ea79350584e0063175a64df29178422c767c1f4b#27267090065)) `test/test_transforms.py::TestActionDiscretizer::test_trans_parallel_env_check[False]`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

matteobettini commented 2 months ago

Is this bc-breaking? Since we had tests that worked and they don't, should the users be informed of anything?

nono, not bc-breaking, the tests had some narrow assumpions that have been extended.