pytorch / rl

A modular, primitive-first, python-first PyTorch library for Reinforcement Learning.
https://pytorch.org/rl
MIT License
2.19k stars 289 forks source link

[BugFix] `EnvBase._complete_done` to complete "terminated" key properly #2294

Closed kurtamohler closed 1 month ago

kurtamohler commented 1 month ago

Description

Fix the logic in EnvBase._complete_done to properly complete the "terminated" key.

Motivation and Context

close #2291

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

Checklist

Go over all the following points, and put an x in all the boxes that apply. If you are unsure about any of these, don't hesitate to ask. We are here to help!

pytorch-bot[bot] commented 1 month ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2294

Note: Links to docs will display an error until the docs builds have been completed.

:x: 6 New Failures, 1 Pending, 1 Unrelated Failure

As of commit ff7ec8211a6e5e8f0d14a8239bc6e13b62931ec6 with merge base f764c0253c88a9faeecfa406c0bc29a5031e70a4 (image):

NEW FAILURES - The following jobs have failed:

* [Continuous Benchmark (PR) / CPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2294#27599746818) ([gh](https://github.com/pytorch/rl/actions/runs/9986726637/job/27599746818)) `Workflow failed! Resource not accessible by integration` * [Continuous Benchmark (PR) / GPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2294#27599747152) ([gh](https://github.com/pytorch/rl/actions/runs/9986726637/job/27599747152)) `Workflow failed! Resource not accessible by integration` * [Habitat Tests on Linux / tests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2294#27599748333) ([gh](https://github.com/pytorch/rl/actions/runs/9986726691/job/27599748333)) `RuntimeError: Command docker exec -t 9351c345c2f6b8e66c2f4345aed144b1a7bd978f4588dead4a1ed1e84d047ece /exec failed with exit code 139` * [Libs Tests on Linux / unittests-gym (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2294#27599754080) ([gh](https://github.com/pytorch/rl/actions/runs/9986726683/job/27599754080)) `AttributeError: module 'torch' has no attribute 'compiler'` * [Unit-tests on Linux / tests-gpu (3.10, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2294#27599750988) ([gh](https://github.com/pytorch/rl/actions/runs/9986726667/job/27599750988)) `RuntimeError: Command docker exec -t db237af9279592b9b63c5c3bf846eb376dffad1e6c79345b5ce1604d4d546b52 /exec failed with exit code 1` * [Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2294#27599751504) ([gh](https://github.com/pytorch/rl/actions/runs/9986726667/job/27599751504)) `AttributeError: module 'torch' has no attribute 'compiler'`

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

* [Unit-tests on Windows / unittests-cpu / windows-job](https://hud.pytorch.org/pr/pytorch/rl/2294#27599747157) ([gh](https://github.com/pytorch/rl/actions/runs/9986726678/job/27599747157)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/f764c0253c88a9faeecfa406c0bc29a5031e70a4#27312262021)) `test/test_transforms.py::TestActionDiscretizer::test_trans_parallel_env_check[False]`

This comment was automatically generated by Dr. CI and updates every 15 minutes.