[Feature] Add `modules.AdditiveGaussianModule`

kurtamohler commented 1 month ago

Description

Add AdditiveGaussianModule, which serves the same purpose as AdditiveGaussianWrapper, but derives from TensorDictModuleBase rather than TensorDictModuleWrapper

Motivation and Context

part of #2295

[x] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

[x] New feature (non-breaking change which adds core functionality)
[x] Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply. If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide (required)
[x] My change requires a change to the documentation.
[x] I have updated the tests accordingly (required for a bug fix or a new feature).
[x] I have updated the documentation accordingly.

pytorch-bot[bot] commented 1 month ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2296

:page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

:x: 11 New Failures, 1 Pending, 2 Unrelated Failures

As of commit c818f12d2d6c234c99d72f3f14525d0f1b3e16a3 with merge base c4b2eb0e0856da812fb9de13170e96fa185ec42b ():

NEW FAILURES - The following jobs have failed:

* [Continuous Benchmark (PR) / CPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2296#27673602724) ([gh](https://github.com/pytorch/rl/actions/runs/10011043904/job/27673602724)) `Workflow failed! Resource not accessible by integration` * [Continuous Benchmark (PR) / GPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2296#27673603075) ([gh](https://github.com/pytorch/rl/actions/runs/10011043904/job/27673603075)) `Workflow failed! Resource not accessible by integration` * [Habitat Tests on Linux / tests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673603989) ([gh](https://github.com/pytorch/rl/actions/runs/10011043916/job/27673603989)) `RuntimeError: Command docker exec -t b48469dad52f5317c06455bf283bd76165cdf79dfaf107944225863c6b4862cf /exec failed with exit code 139` * [Unit-tests on Linux / tests-cpu (3.10) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673604586) ([gh](https://github.com/pytorch/rl/actions/runs/10011043919/job/27673604586)) `test/test_rb.py::TestStorages::test_state_dict[TensorStorage-tensorclass]` * [Unit-tests on Linux / tests-cpu (3.11) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673604935) ([gh](https://github.com/pytorch/rl/actions/runs/10011043919/job/27673604935)) `test/test_rb.py::TestStorages::test_state_dict[TensorStorage-tensorclass]` * [Unit-tests on Linux / tests-cpu (3.8) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673605471) ([gh](https://github.com/pytorch/rl/actions/runs/10011043919/job/27673605471)) `test/test_rb.py::TestStorages::test_state_dict[TensorStorage-tensorclass]` * [Unit-tests on Linux / tests-cpu (3.9) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673605996) ([gh](https://github.com/pytorch/rl/actions/runs/10011043919/job/27673605996)) `test/test_rb.py::TestStorages::test_state_dict[TensorStorage-tensorclass]` * [Unit-tests on Linux / tests-gpu (3.10, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673606242) ([gh](https://github.com/pytorch/rl/actions/runs/10011043919/job/27673606242)) `test/test_rb.py::TestStorages::test_state_dict[TensorStorage-tensorclass]` * [Unit-tests on Linux / tests-optdeps (3.10, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673606665) ([gh](https://github.com/pytorch/rl/actions/runs/10011043919/job/27673606665)) `test/test_rb.py::TestStorages::test_state_dict[TensorStorage-tensorclass]` * [Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673606855) ([gh](https://github.com/pytorch/rl/actions/runs/10011043919/job/27673606855)) `test/test_rb.py::TestStorages::test_state_dict[TensorStorage-tensorclass]` * [Unit-tests on Windows / unittests-cpu / windows-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673603456) ([gh](https://github.com/pytorch/rl/actions/runs/10011043932/job/27673603456)) `The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128`

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

* [Libs Tests on Linux / unittests-gym (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673609232) ([gh](https://github.com/pytorch/rl/actions/runs/10011043915/job/27673609232)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/c4b2eb0e0856da812fb9de13170e96fa185ec42b#27609499215)) `AttributeError: module 'torch' has no attribute 'compiler'` * [Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2296#27673606475) ([gh](https://github.com/pytorch/rl/actions/runs/10011043919/job/27673606475)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/c4b2eb0e0856da812fb9de13170e96fa185ec42b#27609498262)) `AttributeError: module 'torch' has no attribute 'compiler'`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kurtamohler commented 1 month ago

I've added the deprecation warning

pytorch / rl