pytorch / rl

A modular, primitive-first, python-first PyTorch library for Reinforcement Learning.
https://pytorch.org/rl
MIT License
2.27k stars 302 forks source link

[BugFix] TensorDictPrimer updates spec instead of overwriting #2332

Closed matteobettini closed 2 months ago

matteobettini commented 2 months ago

fixes #2331

it also solves the last issue in #2327

pytorch-bot[bot] commented 2 months ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2332

Note: Links to docs will display an error until the docs builds have been completed.

:x: 4 New Failures, 4 Unrelated Failures

As of commit 50940eef4cbf725800bfdd8e3dd10d627afa250c with merge base da898261ba18cb221a0c3b54a679b692c3610f06 (image):

NEW FAILURES - The following jobs have failed:

* [Continuous Benchmark (PR) / CPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2332#28175387166) ([gh](https://github.com/pytorch/rl/actions/runs/10177129271/job/28175387166)) `Workflow failed! Resource not accessible by integration` * [Continuous Benchmark (PR) / GPU Pytest benchmark](https://hud.pytorch.org/pr/pytorch/rl/2332#28175387569) ([gh](https://github.com/pytorch/rl/actions/runs/10177129271/job/28175387569)) `Workflow failed! Resource not accessible by integration` * [Habitat Tests on Linux / tests (3.9, 12.1) / linux-job](https://hud.pytorch.org/pr/pytorch/rl/2332#28175389868) ([gh](https://github.com/pytorch/rl/actions/runs/10177129303/job/28175389868)) `RuntimeError: Command docker exec -t e6cb1501a2028a974fa5ae95dd4c11e646b42573608b3b62ad787f4c5058b79c /exec failed with exit code 139` * [Unit-tests on Windows / unittests-cpu / windows-job](https://hud.pytorch.org/pr/pytorch/rl/2332#28175390438) ([gh](https://github.com/pytorch/rl/actions/runs/10177129320/job/28175390438)) `The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128`

FLAKY - The following job failed but was likely due to flakiness present on trunk:

* [Build Windows Wheels / pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cuda11_8](https://hud.pytorch.org/pr/pytorch/rl/2332#28185890158) ([gh](https://github.com/pytorch/rl/actions/runs/10177129338/job/28185890158)) ([similar failure](https://hud.pytorch.org/pytorch/rl/commit/50940eef4cbf725800bfdd8e3dd10d627afa250c#28185889903)) `Unable to find any artifacts for the associated workflow`

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

* [Build Windows Wheels / pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cpu](https://hud.pytorch.org/pr/pytorch/rl/2332#28185889903) ([gh](https://github.com/pytorch/rl/actions/runs/10177129338/job/28185889903)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/da898261ba18cb221a0c3b54a679b692c3610f06#28130965384)) `Unable to find any artifacts for the associated workflow` * [Build Windows Wheels / pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cuda12_1](https://hud.pytorch.org/pr/pytorch/rl/2332#28185890406) ([gh](https://github.com/pytorch/rl/actions/runs/10177129338/job/28185890406)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/da898261ba18cb221a0c3b54a679b692c3610f06#28130966085)) `Unable to find any artifacts for the associated workflow` * [Build Windows Wheels / pytorch/rl (pytorch/rl, python packaging/wheel/relocate.py, test/smoke_test.py, torchrl) / upload / wheel-py3_9-cuda12_4](https://hud.pytorch.org/pr/pytorch/rl/2332#28185890660) ([gh](https://github.com/pytorch/rl/actions/runs/10177129338/job/28185890660)) ([trunk failure](https://hud.pytorch.org/pytorch/rl/commit/da898261ba18cb221a0c3b54a679b692c3610f06#28130966259)) `Unable to find any artifacts for the associated workflow`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

matteobettini commented 2 months ago

I added the test