Open lgarciaCoveo opened 3 years ago
Hi @lgarciaCoveo I'll check which PR introduced this but regardless the reasoning there is we don't want to overwrite whatever version of torch you're already using
If this is a fresh dev machine then you can run this script https://github.com/pytorch/serve/blob/master/ts_scripts/install_dependencies.py
Hello! Did you have a chance to look into this? @msaroufim
The solution you propose did not help us since we use torchserve inside our own serving library. Our library is in turn used by several teams to launch their models.
Hi @lxning it seems like a regression was introduced in this PR https://github.com/pytorch/serve/commit/8779c5d752196099bebdae036426cededda31359#diff-7e5ecbe5cca38cc12404eb53257e51113407e11d26e30f29d64fb94779500853R14
Is there any valid a reason why a message would be decoded as a tensor? https://github.com/pytorch/serve/commit/8779c5d752196099bebdae036426cededda31359#diff-7e5ecbe5cca38cc12404eb53257e51113407e11d26e30f29d64fb94779500853R118
Ok so the reason why this dependency exists was to support our workflows feature where intermediate nodes would output tensors. We are revamping this feature substantially in a coming release but for now will need to keep it.
I see that this was closed. Is there a PR that solves this?
So the reason this dependency exists is because we need it to support intermediate values in workflows. So we closed the issue because we had no plans of fixing this.
Some more recent discussions have happened though where we've decided to refactor workflows and make it more pythonic and won't require the torch dependency any longer. But we would need to spend some time doing a soft deprecation which is something we're looking into but is not an urgent priority
Cc @maaquib
Hi, is there any update on this ?
Context
As of
torchserve 0.4.0
there is a dependency ontorch
. I came to realize this when moving from0.3.1
to0.4.0
, simply updating the version oftorchserve
in my project and then launching the docker that loads a .mar threw the following error:Details
Now otf_message_handler.py imports torch:
But torch is not listed in the dependency list of torchserve. Looking at the serve/setup.py torchserve is not presented in the
requirements
list:Is this expected?
Your Environment
Expected Behavior
Torchserve should be installable as a standalone framework without a dependency on Torch
Current Behavior
Unable to instal
torchserve
without installingtorch
as wellPossible Solution
Remove dependency on
torch
Steps to Reproduce
torchserve
to version0.4.0
torch
is not installed in the same environmentFailure Logs [if any]