pytorch / serve

Serve, optimize and scale PyTorch models in production
https://pytorch.org/serve/
Apache License 2.0
4.04k stars 821 forks source link

Replace pkg_resources.packaging with packaging module #3178

Closed namannandan closed 2 weeks ago

namannandan commented 3 weeks ago

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced. Please also list any relevant details for your test configuration.

Checklist:

bstriner commented 2 weeks ago

@namannandan Nice! The container test just shows canceled, maybe just a transient issue you can bump the code to fix? pkg_resources has been deprecated for a long time, doesn't seem like it would need conditional imports, hopefully someone from meta can chip in soon.

udaij12 commented 2 weeks ago

Check #3187