search

pytorch / tensordict

TensorDict is a pytorch dedicated tensor container.
MIT License
803 stars 65 forks source link

[BUG] Flaky tests since map_iter #870

Closed vmoens closed 1 month ago

vmoens commented 1 month ago

The map_iter PR (#847) causes the CI to sporadically fail. I think the failing tests are in TestMap but I'm not 100% sure.

Cause

I believe this is due to the fact that this PR solved an issue previously unknown: before #847, index_with_generator was ignored in map and hence the related test didn't do much.

Now this is fixed. Not sure why but it seems the test is now failing when we use this generator.

I tried various things to fix this in https://github.com/pytorch/tensordict/pull/869 without success

cc @kurtamohler if you want to help!