search

pytorch / tensordict

TensorDict is a pytorch dedicated tensor container.
MIT License
803 stars 65 forks source link

Do not set global validate_args #871

Open mctigger opened 1 month ago

mctigger commented 1 month ago

https://github.com/pytorch/tensordict/blob/02ff68645a1e0950791125671cd9e88ee2592762/tensordict/nn/distributions/continuous.py#L25

Is there a reason for this line? I think it should be removed. validate_args is set to False when python is run in optimized mode (python -O) and True. The default should not be changed since errors may not be caught while developing.

https://github.com/pytorch/tensordict/pull/872