search

pytorch / tensorpipe

A tensor-aware point-to-point communication primitive for machine learning
Other
247 stars 77 forks source link

tensorpipe fails to build on FreeBSD: error: use of undeclared identifier 'getBootIDInternal' #461

Open yurivict opened 1 year ago

yurivict commented 1 year ago 
/usr/ports/math/dgl/work/dgl-1.0.2/third_party/tensorpipe/tensorpipe/common/system.cc:144:41: error: use of undeclared identifier 'getBootIDInternal'
  static optional<std::string> bootID = getBootIDInternal();
                                        ^
1 error generated.

The error occurred while trying to build the DGL library https://github.com/dmlc/dgl

lw commented 1 year ago

That's expected: we have an implementation of that function for Linux and MacOS, but not for FreeBSD: https://github.com/pytorch/tensorpipe/blob/bb1473a4b38b18268e8693044afdb8635bc8351b/tensorpipe/common/system.cc#L53-L80

If you're familiar with FreeBSD feel free to submit a patch! However, FreeBSD isn't really supported or tested, so nothing guarantees that you won't find other issues after this one.