Open clee2000 opened 1 year ago
AI:
@clee2000 We turn off assert rewriting in pytest. We are in a mix situation where we use pytest to run the test but the class still depends on unittest TestCase, otherwise, advance features like retry or disable tests wouldn't work.
Just another data point, @DanilBaibak mentioned during the oncall handoff today about yet another dynamo tests not run on OSS test/dynamo/test_recompile_ux.py
. The good news is that the issue has been fixed in https://github.com/pytorch/pytorch/pull/114235
Adding https://github.com/pytorch/pytorch/pull/115070 for general pytest tracking:
"Pytest replaces sys.stdout/stderr by TextIOWrapper instances which do not support fileno()
" which might affect some test cases
linter has also been merged https://github.com/pytorch/pytorch/pull/114882
Also the distributed dtensor tests running on CPU that @malfet discovers (See https://github.com/pytorch/pytorch/issues/118043 )
re-enable DTensor tests on CPU in #118134
List is no longer accurate, but problem still exists, though nobody is actively looking at it at the moment
The following files do not have a run_tests mentioned in the file but are collected by test/run_tests.py, indicating that they probably aren't being run in CI.
Being on this list does not mean the test file is guaranteed to run as I did not check to see if they actually call run_tests, only that it is mentioned somewhere in the file.