search

pytorch / text

Models, data loaders and abstractions for language processing, powered by PyTorch
https://pytorch.org/text
BSD 3-Clause "New" or "Revised" License
3.51k stars 811 forks source link

Revamp Pytorch Benchmark implementations for pytorch_struct and Attention is All You Need models #1443

Open abhinavarora opened 3 years ago

abhinavarora commented 3 years ago

🚀 Feature

Revamp Pytorch Benchmark implementations for pytorch_struct and Attention is All You Need models

Motivation Since we deprecated pytorch.legacy, we need to revamp these tutorials to make them adhere to newer TorchText APIs.

erip commented 2 years ago

Where can these be found? I'd be happy to take a stab at this.

mthrok commented 2 years ago

This?

https://github.com/pytorch/benchmark/blob/121ea0230d9f675928625b9a9c83d4cd9772f27f/torchbenchmark/models/pytorch_struct/__init__.py

https://github.com/pytorch/benchmark/tree/121ea0230d9f675928625b9a9c83d4cd9772f27f/torchbenchmark/models/attention_is_all_you_need_pytorch

erip commented 2 years ago

Just started this. Tracking here.

erip commented 2 years ago

I think the pytorch_struct refactor is ready for review: https://github.com/pytorch/benchmark/pull/673 cc @mthrok @abhinavarora

xuzhao9 commented 2 years ago

Due to a recent code change in torchtext(https://github.com/pytorch/text/pull/1654), another workaround is added: https://github.com/pytorch/benchmark/pull/795