Simplify torchdata version extraction in packaging script

pytorch / text

Models, data loaders and abstractions for language processing, powered by PyTorch

https://pytorch.org/text

BSD 3-Clause "New" or "Revised" License

3.49k stars 815 forks source link

Simplify torchdata version extraction in packaging script #2129

Closed atalman closed 1 year ago

atalman commented 1 year ago

Simplify torchdata version extraction in packaging script test:

conda list -fe torchdata 
# This file may be used to create an environment using:
# $ conda create --name <env> --file <this file>
# platform: linux-64
torchdata=0.7.0.dev20230328=py310

conda list -fe torchdata | grep torchdata | sed -e 's/torchdata=\(.*\)=py.*/\1/'
0.7.0.dev202303283

github-advanced-security[bot] commented 1 year ago

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:build. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

osalpekar commented 1 year ago

@atalman Looks like Linux Conda release jobs start failing from this PR. Nightlies were fine until 03/27 and started failing on 03/28: https://github.com/pytorch/text/actions/workflows/build-conda-linux.yml?query=event%3Apush+branch%3Anightly. We might need to revert/refactor this to get nightlies green again (looks like we are affecting the version compatibility based on the build error).

cc @joecummings