Allow overwriting of local SPM model path

pytorch / text

Models, data loaders and abstractions for language processing, powered by PyTorch

https://pytorch.org/text

BSD 3-Clause "New" or "Revised" License

3.51k stars 811 forks source link

Allow overwriting of local SPM model path #2136

Closed joecummings closed 1 year ago

joecummings commented 1 year ago

Fixes issue in which some download managers (Manifold) do not successfully download the SPM model; however, because the file has been created, the model does not attempt another redownload and instead tries to load an empty file.

Bug was found and fix authored by @debowin

joecummings commented 1 year ago

@osalpekar These Macos build errors don't seem to be coming from changes to this PR - can you take a look?

github-advanced-security[bot] commented 1 year ago

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:build. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

osalpekar commented 1 year ago

@DanilBaibak @atalman Any ideas what these MacOS issues are (both in Unittests and Build workflows)? Anything changed in the configuration for those instances? Also with MacOS x86 support being deprecated, do we want to start phasing these jobs out from domains as well?