search

pytorch / text

Models, data loaders and abstractions for language processing, powered by PyTorch
https://pytorch.org/text
BSD 3-Clause "New" or "Revised" License
3.49k stars 813 forks source link

Use `filelock` library for file downloads #2166

Closed Nayef211 closed 1 year ago

Nayef211 commented 1 year ago

Summary: Followup to D44604474 and D45048667. The previous 2 solutions didn't work because neither iopath nor fcntl implement platform agnostic locks. Thus the changes in the internal diffs could not be landed on github.

Using filelock should resolve the issue as it implements a platform agnostic file lock mechanism. This solution is also used by PyTorch Core to implement locking (see code pointer).

Reviewed By: debowin

Differential Revision: D45234254

fbshipit-source-id: 2285f94b13e36685ec6a5c1c4d2cd74dee9e0431

pytorch-bot[bot] commented 1 year ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2166

Note: Links to docs will display an error until the docs builds have been completed.

:x: 1 New Failure, 1 Pending

As of commit 9cc4408277537d415ce3ce8410d66cdf3a5b957c: <details open}>

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.