search

pytorch / text

Models, data loaders and abstractions for language processing, powered by PyTorch
https://pytorch.org/text
BSD 3-Clause "New" or "Revised" License
3.49k stars 813 forks source link

Add TorchFix linter #2179

Closed kit1980 closed 1 year ago

kit1980 commented 1 year ago

Add TorchFix linter and fix deprecated usages of assert_allclose to make it pass.

Also move the comments in the flake8 config to separate lines, as more modern flake8 versions do not support inline comments for any of the keys - https://flake8.pycqa.org/en/latest/user/configuration.html

The bandit failure and M1 failures are pre-existing.

pytorch-bot[bot] commented 1 year ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2179

Note: Links to docs will display an error until the docs builds have been completed.

:x: 7 New Failures

As of commit 370019ae6d5f2406ae794c567e738c549f30c030:

NEW FAILURES - The following jobs have failed:

* [Bandit](https://hud.pytorch.org/pr/pytorch/text/2179#5250019440) ([gh](https://github.com/pytorch/text/actions/runs/5250019440)) * [Build M1 Conda](https://hud.pytorch.org/pr/pytorch/text/2179#5250019480) ([gh](https://github.com/pytorch/text/actions/runs/5250019480)) * [tests (3.8) / macos-job](https://hud.pytorch.org/pr/pytorch/text/2179#14206225982) ([gh](https://github.com/pytorch/text/actions/runs/5250019482/jobs/9483500170)) * [tests (3.8) / windows-job](https://hud.pytorch.org/pr/pytorch/text/2179#14206225739) ([gh](https://github.com/pytorch/text/actions/runs/5250019481/jobs/9483500006)) * [tests (3.9) / linux-job](https://hud.pytorch.org/pr/pytorch/text/2179#14206225842) ([gh](https://github.com/pytorch/text/actions/runs/5250019470/jobs/9483500084)) * [tests (3.9) / macos-job](https://hud.pytorch.org/pr/pytorch/text/2179#14206225718) ([gh](https://github.com/pytorch/text/actions/runs/5250019482/jobs/9483499989)) * [tests (3.9) / windows-job](https://hud.pytorch.org/pr/pytorch/text/2179#14206226063) ([gh](https://github.com/pytorch/text/actions/runs/5250019481/jobs/9483500238))

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kit1980 commented 1 year ago

The tests failing are also pre-existing, see the same errors on a dummy change https://github.com/pytorch/text/pull/2180

So merging this PR.