Conda nightly build to Github Actions

bearzx commented 2 years ago

In this PR I'm added a new Github workflow to enable nightly build for conda. But right now for developing and testing, I left the trigger as new PR comes in, so it's not really "nightly build" yet.

Multiple points to note:

Since Github Action machines mac don't support AVX instructions, I left the test blank for mac builds, and only enabled it for linux build.
For some reason, glog needs to be on 0.4.0 version (latest 0..5.0) to make the testing part work (even it's just a simple import), otherwise some symbol not found error will arise. I think it has something to do with glog itself, so I'm leaving the workaround as is for now.
I actually tried to run the unit tests with linux build, and it mostly worked except for two that need to check package names. I think when running tests from conda the top level folder is just torcharrow, so the failing tests will have messages like "torcharrow.test" != "test". I'll leave this to further investigation and depending on whether we really want to run unittests in conda build workflows, we may end up not bothering with it.

This PR finishes the building part, but I still need to upload the built artifact to conda, which I'll leave as a todo.

facebook-github-bot commented 2 years ago

@bearzx has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

wenleix commented 2 years ago

For some reason, glog needs to be on 0.4.0 version (latest 0..5.0) to make the testing part work (even it's just a simple import), otherwise some symbol not found error will arise.

cc @kgpai . Wondering if this has been known from other Velox users?

facebook-github-bot commented 2 years ago

@bearzx has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

kgpai commented 2 years ago

@wenleix we explicitly depend on glog v 0.4.0 . I havent upgraded to 0.5.0 to see if they are compatible, but based on error it probably isnt.

bearzx commented 2 years ago

@wenleix we explicitly depend on glog v 0.4.0 . I havent upgraded to 0.5.0 to see if they are compatible, but based on error it probably isnt.

Yeah building itself seems to be fine, but when testing it'll need glog to be on 0.4.0 as 0.5.0 removed some non-public symbols, which caused errors. Here's a discussion for this issue that I found: https://trac.macports.org/ticket/62921

facebook-github-bot commented 2 years ago

@bearzx has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@bearzx has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pytorch / torcharrow

Conda nightly build to Github Actions #319