search

pytorch / torcharrow

High performance model preprocessing library on PyTorch
https://pytorch.org/torcharrow/beta/index.html
BSD 3-Clause "New" or "Revised" License
649 stars 79 forks source link

Set VELOX_DISABLE_GOOGLETEST ON for TorchArrow #352

Closed wenleix closed 2 years ago

wenleix commented 2 years ago

Disable GTest for TorchArrow

Starts to fail with https://github.com/facebookincubator/velox/commit/118feb5d1b946caa614aeb46ccf142c50cd7ddec

It looks like the compiler flag set at https://github.com/facebookincubator/velox/blob/118feb5d1b946caa614aeb46ccf142c50cd7ddec/CMakeLists.txt#L317 doesn't affects the outer-level project compiler flag (i.e. TorchArrow, which use Velox as a submodule)

Thus manually set up VELOX_DISABLE_GOOGLETEST compiler flag.

wenleix commented 2 years ago

Needs https://github.com/facebookincubator/velox/pull/1745

wenleix commented 2 years ago

See discussions in https://github.com/facebookincubator/velox/pull/1666#issuecomment-1143044716

facebook-github-bot commented 2 years ago

@wenleix has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.