search

pytorch / torcharrow

High performance model preprocessing library on PyTorch
https://pytorch.org/torcharrow/beta/index.html
BSD 3-Clause "New" or "Revised" License
649 stars 79 forks source link

Introduce wheel build workflow for release #368

Closed bearzx closed 2 years ago

bearzx commented 2 years ago

In this PR I added another GHA for the beta release. It's mostly copied from nightly-wheel.yml so some refactoring or unification work can be forseen in the future. But here I wanted it to start simple and separate.

The workflow will checkout the release branch, build, run the criteo integration test, then upload it to github so it can be retrieved to upload to pypi.

TODO: since release/0.1.0 is already created, after this PR is merged to main, I'll need to merge the main branch to release/0.1.0.

facebook-github-bot commented 2 years ago

@bearzx has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@bearzx has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

wenleix commented 2 years ago

Consider to use git commit --amend and do force push unless it's some "major changes" that you want to keep the commit history :)

bearzx commented 2 years ago

Consider to use git commit --amend and do force push unless it's some "major changes" that you want to keep the commit history :)

cool yeah I used the --amend arg once but it still appeared in the history, now I know I forgot the force push part :D

facebook-github-bot commented 2 years ago

@bearzx has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.