Minor changes to setup scripts

pytorch / torcharrow

High performance model preprocessing library on PyTorch

https://pytorch.org/torcharrow/beta/index.html

BSD 3-Clause "New" or "Revised" License

649 stars 79 forks source link

Minor changes to setup scripts #395

Closed wenleix closed 2 years ago

wenleix commented 2 years ago

Update folly version to be consistent with Velox: https://github.com/facebookincubator/velox/blob/c4237370e40fce925a5c34bd805008248d42684f/scripts/setup-ubuntu.sh#L25
Minor config flag change (e.g. disable testing), following https://github.com/facebookincubator/velox/blob/04a85f7cb7fcc2eaa3b30b1749c3d97b3bba8676/scripts/setup-macos.sh#L104 and https://github.com/facebookincubator/velox/blob/04a85f7cb7fcc2eaa3b30b1749c3d97b3bba8676/scripts/setup-macos.sh#L109

facebook-github-bot commented 2 years ago

@wenleix has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 years ago

@wenleix has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

wenleix commented 2 years ago

@bearzx : agree. One thing need to figure out is I would still like the developer to be able to execute scripts/setup-xxx.sh in https://github.com/pytorch/torcharrow#install-dependencies , rather than using csrc/velox/velox/velox/scripts/.... Maybe we can let scripts/setup-xxx.sh to delegate to csrc/velox/velox/velox/scripts/... ? :)

We also need to confirm with Velox team that these scripts will be existed and supported (otherwise, if some day Velox repo rename / removed the script, TorchArrow build would also fail). cc @kgpai

kgpai commented 2 years ago

@wenleix Yes, they will be supported . They are also used for presto_cpp so no reason for TA not to rely on them.