search

pytorch / torcharrow

High performance model preprocessing library on PyTorch
https://pytorch.org/torcharrow/beta/index.html
BSD 3-Clause "New" or "Revised" License
642 stars 78 forks source link

Pass not nullable context and results by reference (#2367) #479

Closed laithsakka closed 2 years ago

laithsakka commented 2 years ago

Summary: X-link: https://github.com/facebookincubator/velox/pull/2367

Those are always assumed not null and de-referenced with out checking, hence passing them by reference is more suitable.

Differential Revision: D38946493

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D38946493

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D38946493

wenleix commented 2 years ago

Landed into fbsync as https://github.com/pytorch/torcharrow/commit/458dc0bcbc778b6957afb08248c86f2a5ceaead1 and cherry-pick into main branch as https://github.com/pytorch/torcharrow/pull/483