EBC backward numeric correctness tests

pytorch / torchrec

Pytorch domain library for recommendation systems

BSD 3-Clause "New" or "Revised" License

1.79k stars 381 forks source link

EBC backward numeric correctness tests #2162

Closed IvanKobzarev closed 1 week ago

IvanKobzarev commented 1 week ago

Summary: Adding numeric correctness check for backward. Verifying that TBE inplace weights updates are numerically correct with eager updates, float inputs with requires_grad grads are numerically correct with eager grads.

I saw some data dependent errors on subsequent inputs for VB path, disabling checks for extra inputs for now (n_extra_numerics_checks_inputs = 0 and TODO in the source).

Differential Revision: D58948988

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D58948988