pytorch / torchrec

Pytorch domain library for recommendation systems
BSD 3-Clause "New" or "Revised" License
1.79k stars 381 forks source link

Enable non-VB inductor compilation, backward extra numerics checks #2178

Closed IvanKobzarev closed 1 week ago

IvanKobzarev commented 1 week ago

Summary: The recent D58956327 addition of fbgemm kernel without lengths view transformations was the last piece to enable non-VB inductor compilation.

Enabling inductor compilation for non-VB path.

Adding torch._dynamo.config.force_unspec_int_unbacked_size_like_on_torchrec_kjt = True dynamo config, which was the reason of extra numerics failures (due to recompilation) => Enable extra numerics checks for VB - backward.

Differential Revision: D59057596

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D59057596