Maybe this a a bug in criteo.py

pytorch / torchrec

Pytorch domain library for recommendation systems

BSD 3-Clause "New" or "Revised" License

1.87k stars 405 forks source link

Maybe this a a bug in criteo.py #2308

Open ywangwxd opened 3 weeks ago

ywangwxd commented 3 weeks ago

The change of code is as the following screenshot: 1, in the first screenshot, if hashes is default None, this line will cause error 2, in the second screenshot, if mmap_mode is false, it means no hashing needed?

PaulZhang12 commented 3 weeks ago

Can you provide more context/ a repro?