Closed rodrigodesalvobraz closed 14 hours ago
This pull request was exported from Phabricator. Differential Revision: D66281917
This pull request was exported from Phabricator. Differential Revision: D66281917
This pull request was exported from Phabricator. Differential Revision: D66281917
Summary: Continue improvements to
EmbeddingBagCollection
:_{f,i}
by Python-like notation[f][i]
Futhermore, improve documentation of related classes:
EmbeddingCollection
had documentation similar to the previous version ofEmbeddingBagCollection
documentation, so it is now updated to the style of the new documentation, for consistency as well as greater precision and clarity.fbcode/torchrec/quant/embedding_modules.py
redefinesEmbeddingBagCollection
in a distinct package, and simply duplicated the main implementation of the original class, with a few differentiating comments. Instead of merely copying-and-pasting the new documentation to this class, we change the documentation preserve the differentiating comments and merely refer to the original class documentation. This prevents duplication and possible future inconsistencies, and mirrors what other redefinitions of this class do.Differential Revision: D66281917