[WIP] Sample packing deep dive

RdoubleA commented 2 weeks ago

Context

Deep dive in live docs on sample packing with in-sample masking and position encoding and how it impacts training throughput and model quality

[ ] add a new feature
[ ] fix a bug
[x] update tests and/or documentation
[ ] other (please add here)

Test plan

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

[ ] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[ ] add unit tests for any new functionality
[ ] update docstrings for any new or updated methods or classes
[ ] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness
- [ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

pytorch-bot[bot] commented 2 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1083

:page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

:x: 1 New Failure

As of commit 9286a0fc6b34c960f54c37de26989e3eaf7435d1 with merge base 0e0aff0bbfeb3e67175ccdab391d539284831ae2 ():

NEW FAILURE - The following job has failed:

* [Build Docs / build_docs (3.11)](https://hud.pytorch.org/pr/pytorch/torchtune/1083#26159345117) ([gh](https://github.com/pytorch/torchtune/actions/runs/9492349980/job/26159345117))

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ebsmothers commented 1 week ago

doc build failed

pytorch / torchtune