search

pytorch / torchtune

A Native-PyTorch Library for LLM Fine-tuning
https://pytorch.org/torchtune/main/
BSD 3-Clause "New" or "Revised" License
4.05k stars 370 forks source link

fix torchtune import from torchao after refactor #1088

Closed jerryzh168 closed 3 months ago

jerryzh168 commented 3 months ago

Summary: att

Reviewed By: SLR722

Differential Revision: D58506712

pytorch-bot[bot] commented 3 months ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1088

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 36a6f10ac7a310d608123136e042e84718b4e424 with merge base 1759a239a7eceb07ae7b43f33893bb4021d57a4c (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D58506712

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D58506712

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D58506712

pbontrager commented 3 months ago

Thanks for this fix. Could you leave a comment specifying what that import is doing? Also it appears we're importing a lot of unused imports.

jerryzh168 commented 3 months ago

Thanks for this fix. Could you leave a comment specifying what that import is doing? Also it appears we're importing a lot of unused imports.

sure, this is for deciding what quantizer to include, it's used in L48 in the file

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D58506712

facebook-github-bot commented 3 months ago

This pull request was exported from Phabricator. Differential Revision: D58506712

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.57%. Comparing base (74fb5e4) to head (36a6f10). Report is 5 commits behind head on main.

Files Patch % Lines
torchtune/utils/quantization.py 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1088 +/- ## =========================================== + Coverage 26.66% 66.57% +39.91% =========================================== Files 183 183 Lines 8326 8329 +3 =========================================== + Hits 2220 5545 +3325 + Misses 6106 2784 -3322 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.