Remove unused FSDP1 components

krammnic commented 3 weeks ago

Context

What is the purpose of this PR? Is it to

[ ] add a new feature
[ ] fix a bug
[ ] update tests and/or documentation
[X] Clean up

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?

1897

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

[X] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[ ] add unit tests for any new functionality
[X] update docstrings for any new or updated methods or classes
[X] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness
[ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it. Here is a docstring example and a tutorial example

[X] I did not change any public API
[ ] I have added an example to docs or docstrings

pytorch-bot[bot] commented 3 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1933

:page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

krammnic commented 3 weeks ago

Probably need to remove relations to docs

ebsmothers commented 3 weeks ago

Thanks for the PR! Looking at the code changes now, but at least for the doc build job failure you will need to remove this line (you can check other rst files the same folder for any other APIs you've removed, their references will need to be removed as well)

krammnic commented 3 weeks ago

Probably fine now

ebsmothers commented 2 weeks ago

Looks like CI is red?

SalmanMohammadi commented 2 weeks ago

I think you also need to remove the reference to validate_state_dict_for_lora in the API docs @krammnic

SalmanMohammadi commented 2 weeks ago

Hey @krammnic - think there's some merge conflicts to fix before I can kick off CI again.

ebsmothers commented 1 week ago

@krammnic I’m gonna close this now that #2016 has landed. Thanks for your work on this one!

pytorch / torchtune