pytorch / torchtune

PyTorch native finetuning library
https://pytorch.org/torchtune/main/
BSD 3-Clause "New" or "Revised" License
4.37k stars 446 forks source link

[Bug] model_type argument as str for checkpoints classes #1946

Closed smujjiga closed 3 weeks ago

smujjiga commented 3 weeks ago

What is the purpose of this PR? Is it to

The correct usage of model_type argument is as a string as shown here

pytorch-bot[bot] commented 3 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1946

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit ca6f70720b40abd41e9d44f4cb25aed68887ef01 with merge base e861954d43d23f03f2857b0556916a8431766d5d (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ebsmothers commented 3 weeks ago

Thanks @smujjiga for the fix! This looks good to me, once CI is green we can merge