pytorch / torchtune

PyTorch native finetuning library
https://pytorch.org/torchtune/main/
BSD 3-Clause "New" or "Revised" License
4.35k stars 440 forks source link

feat(cli): allow users to download models from Kaggle #2002

Closed KeijiBranshi closed 1 day ago

KeijiBranshi commented 1 week ago

Context

What is the purpose of this PR? Is it to

Please link to any issues this PR addresses.

https://github.com/pytorch/torchtune/issues/1852

Changelog

What are the changes made in this PR?

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it. Here is a docstring example and a tutorial example

pytorch-bot[bot] commented 1 week ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2002

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

:white_check_mark: No Failures

As of commit 00493ef2b493a206b46fa67632962f9e7dce8b99 with merge base d9b6c792f23c7e35dcb4a3a29fee0f30f54f4894 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

joecummings commented 1 week ago

Awesome stuff!! Will be reviewing this today or tomorrow :)

KeijiBranshi commented 3 days ago

Will wait for CI, but LGTM!

Thanks @KeijiBranshi for your hard work on this and making it easier for torchtune users to download models from the Kaggle Hub!

Thanks so much for your help and review! Really appreciated your guidance on everything.

Looks like some of my test are failing. Could've sworn I ran before pushing, but i guess it slipped through. Resolving those now πŸ™‚

KeijiBranshi commented 3 days ago

@joecummings success!

Thanks again for all your help. Let me know if anything else needs to be done for the release process πŸš€

KeijiBranshi commented 2 days ago

@joecummings quick fyi, I just rebased to the most recent main branch commit.

Let us know if there's anything else we should do to get this merged πŸ™‚

joecummings commented 1 day ago

@joecummings quick fyi, I just rebased to the most recent main branch commit.

Let us know if there's anything else we should do to get this merged πŸ™‚

Thanks for the rebase. Will merge this today!! Afterwards, I'll kick off a "nightly" build so users can have immediate access to this feature even before tomorrow's build of torchtune.

KeijiBranshi commented 1 day ago

@joecummings quick fyi, I just rebased to the most recent main branch commit. Let us know if there's anything else we should do to get this merged πŸ™‚

Thanks for the rebase. Will merge this today!! Afterwards, I'll kick off a "nightly" build so users can have immediate access to this feature even before tomorrow's build of torchtune.

Thank you so much!! Looking forward to it.

Please ping me if things break or users see issues πŸ™‚. If I'm unresponsive for any reason, you can also email kaggle-models@google.com.