search

pytorch / torchx

TorchX is a universal job launcher for PyTorch applications. TorchX is designed to have fast iteration time for training/research and support for E2E production ML pipelines when you're ready.
https://pytorch.org/torchx
Other
306 stars 99 forks source link

feat: add privileged option to local_docker (#897) #898

Closed clumsy closed 1 week ago

clumsy commented 1 month ago

Adding privileged option for local_docker so that the container can start in privileged mode, same way we can do this for aws_batch scheduler. Defaults to False, same as in aws_batch.

Test plan: ☑ unit test added ☑ tested locally:

docker inspect --format='{{.HostConfig.Privileged}}' <CONTAINER_ID>
true
clumsy commented 1 month ago

For your consideration, @kiukchung

clumsy commented 1 month ago

Any chance you can check this request, @d4l3k?

clumsy commented 1 month ago

Any chance you can look at this one, @andywag?

d4l3k commented 2 weeks ago

Also not sure why it's not giving me an option to run the full tests -- maybe need to bump the PR.

@clumsy sorry for the delay in reviews on this

clumsy commented 2 weeks ago

No worries, @d4l3k. Should I force push an amended commit to trigger rebuild?

clumsy commented 2 weeks ago

Addressed your comment, @d4l3k. Please let me know if further modifications are needed.