search

pytorch / tutorials

PyTorch tutorials.
https://pytorch.org/tutorials/
BSD 3-Clause "New" or "Revised" License
8.15k stars 4.05k forks source link

invalid shortlink target #100

Closed andreh7 closed 7 years ago

andreh7 commented 7 years ago

The link https://goo.gl/uGOksc referring to a document 'Train neural nets to play video games' redirects to a non-existing notebook https://github.com/pytorch/tutorials/blob/master/Reinforcement%20(Q-)Learning%20with%20PyTorch.ipynb

This link appears in these files:

Probably what it should link to is https://github.com/pytorch/tutorials/blob/master/intermediate_source/reinforcement_q_learning.py .

(if this is correct and you want to eliminate the short url link like for the other links in these files, I can provide a pull request if wanted)

jnhwkim commented 7 years ago

In the same page, Chat with other users on Slack is also broken in the web page.

chsasank commented 7 years ago

@andreh7, It'd indeed be great if you can raise a PR. Sorry for late reply.

andreh7 commented 7 years ago

As you see in this thread, for the issue reported by @jnhwkim , I submitted pull request #102.

For the issue originally reported by me, I propose pull request #104, I'm new to sphinx so I hope this is in the spirit of the rest of the documentation.

I also noticed that the title of the link mentions video games while the the actual target is about the cart pole problem but the original link was also about reinforcement q learning.

Let me know if I should change something in the pull requests.