search

pytorch / tvm

TVM integration into PyTorch
452 stars 64 forks source link

To aid debugging of TVM lowered graph #123

Closed kimishpatel closed 5 years ago

kimishpatel commented 5 years ago

@yinghai, made changes to consolidate debug stuff. Is that what you had in mind? Also note that this is not a functional debug, this is for perf stuff. I mostly used it to see the schedule tvm used and the quality of the generated code. Was immensely helpful to me in perf debug, but wanted to clarify that this is not for functional debug.

kimishpatel commented 5 years ago

BTW, it needs this PR to land too, else we will get runtime error (I need to fix that so that we dont core dump or something). https://github.com/facebookexperimental/tvm/pull/9. Do you want me to push that in as well?

yinghai commented 5 years ago

Yes, it's accepted. You can upstream that. I think it's fairly reasonable change.

kimishpatel commented 5 years ago

@yinghai, I merged all logging to one logger. You might wanna vet the recent changes. For whatever reason though, with these changes file has some binary dump at the beginning and I could not quite figure it out why, so leaving it as is for now. Will fix it later.