pytorch / vision

Datasets, Transforms and Models specific to Computer Vision
https://pytorch.org/vision
BSD 3-Clause "New" or "Revised" License
16.31k stars 6.97k forks source link

Ability to import CocoEvaluator #3728

Open NielsRogge opened 3 years ago

NielsRogge commented 3 years ago

🚀 Feature

It would be great if we could do the following:

from torchvision import CocoEvaluator

base_ds = dataset.coco
iou_types = ['bbox']
coco_evaluator = CocoEvaluator(base_ds, iou_types) # initialize evaluator with ground truths

model = ... # fancy deep learning model
model.eval()

print("Running evaluation...")
for batch in data_loader:
    outputs = model(**batch)
    result = ... # convert outputs of model to COCO api
    coco_evaluator.update(result)

coco_evaluator.synchronize_between_processes()
coco_evaluator.accumulate()
coco_evaluator.summarize()

Right now, CocoEvaluator cannot be imported as it's currently under the references directory in this repository, it's not part of the torchvision package.

Motivation

I'm currently implementing DETR (end-to-end object detection with Transformers), and right now I have to copy all of this code of COCO evaluation in order to evaluate the model. The authors of DETR also copied a lot of the code for evaluation into their own repository. It would be great if we can simply import it, and run evaluation of a deep learning model.

Even in the official torchvision tutorial, they state that:

"In references/detection/, we have a number of helper functions to simplify training and evaluating detection models. Here, we will use references/detection/engine.py, references/detection/utils.py and references/detection/transforms.py. Just copy everything under references/detection to your folder and use them here." => life would be easier if users don't need to look into Github repos and copy files into their own folder. Also, there would be a central place (namely this repository) where the official COCO evaluation is defined, and can be updated in the future. Right now evaluation is cluttered across hundreds of Github repos.

This would also foster reproducability of experiments with object detection models, as right now it's a lot of work to just evaluate a model with metrics like mAP.

datumbox commented 3 years ago

Thanks for the proposal. We have a few requests of moving stuff out of the references and into the library, so this proposal is in the same direction.

As with similar requests, we need to review the APIs that we have on the references and decide whether they are mature enough so that we commit to them. Unfortunately this use-case has one concern; adding this class in TorchVision will require putting an extra dependency due to the pycocotools imports. Not sure that's the direction we would like to take it but I would like to hear also from @fmassa.

NielsRogge commented 3 years ago

Great, otherwise I would perhaps make a small PyPi package that allows this, but I don't even know if this is allowed, I don't want to take credit for things that are not made by me of course (I would of course cite the torchvision authors and include the license).