pytorch / vision

Datasets, Transforms and Models specific to Computer Vision
https://pytorch.org/vision
BSD 3-Clause "New" or "Revised" License
15.99k stars 6.92k forks source link

Models not pushed to torch hub #4289

Open oke-aditya opened 3 years ago

oke-aditya commented 3 years ago

📚 Documentation

Hi!

The following models are listed in our hubconf.py but these models are not listed over pytorch hub

Additional Context: -

I think there is ongoing issue with torch hub. #4156 Also we do not publish detection models to torch hub see #1945

P.S. Please verify the list and feel to free to edit if I have missed something. Also probably this issue can be transferred to torch hub repository.

cc @datumbox @NicolasHug

datumbox commented 3 years ago

Thanks for bringing this up @oke-aditya. I think it's reasonable to include them.

The only concern I got is for mnasnet0_75 and mnasnet1_3 which don't have pre-trained weights, but all other look good to me. Would you like to send a PR?

oke-aditya commented 3 years ago

Yes, I will! Happy to help :smile:

NicolasHug commented 3 years ago

Thanks @oke-aditya ,

as a minor caveat we should just make sure that those models aren't relying on custom ops, which is the reason why the detection models aren't published yet: https://github.com/pytorch/vision/issues/1945#issuecomment-597062931

(I haven't checked myself)

datumbox commented 3 years ago

All models listed here don't require require custom operators that need compilation. He should be good to go.