pytorch / xla

Enabling PyTorch on XLA Devices (e.g. Google TPU)
https://pytorch.org/xla
Other
2.49k stars 483 forks source link

Confusing text in bazel.md #8379

Open mikegre-google opened 6 days ago

mikegre-google commented 6 days ago

📚 Documentation

The bazil.md file contains the following text:

Bazel brings in pybind11 embeded python and links against it to provide libpython to the plugin using this mechanism. Python headers are also sourced from there instead of depending on the system version. These are satisfied from the "@pybind11//:pybind11_embed", which sets up compiler options for linking with libpython transitively.

From what I can determine:

The text above says "Bazel ... links against pybind to provide libpython to the plugin..."

The text says: "Python headers are also sourced from there instead of depending on the system version. "

The text says: "These are satisfied from the "@pybind11//:pybind11_embed", which sets up compiler options for linking with libpython transitively."

miladm commented 6 days ago

@ManfeiBai can you please help?

mikegre-google commented 5 days ago

bazel.md also states that TensorFlow is a Bazel external dependency and is configured in WORKSPACE, but I looked in pytorch/xla/WORKSPACE and didn't find a reference to TensorFlow. Is this information correct? I couldn't find another WORKSPACE file in the repo.