Add QRCode generator (#21)

pytorn / hackr

A python library for hackathons.

Apache License 2.0

94 stars 31 forks source link

Add QRCode generator (#21) #22

Closed hanksudo closed 7 years ago

hanksudo commented 7 years ago

Fixes #21

shubhodeep9 commented 7 years ago

@hanksudo Hi, I went through the code. Logic is great and simple. Simple suggestion, the tool doesn't seem related to generator, I'd suggest implementing it into image module. Explanation :

Generator exists to generate random and fake values.
Image module already exists for image related tasks. I think using it as hackr.image.qr() would be smart.

hanksudo commented 7 years ago

@shubhodeep9 good suggestion, let me move it into hackr.image module.

shubhodeep9 commented 7 years ago

@hanksudo now its awesome. Cool I will merge it.